feat: add timestamp & decimal type support to java bindings #8740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8740 +/- ##
==========================================
- Coverage 70.78% 70.74% -0.04%
==========================================
Files 1176 1176
Lines 195112 195195 +83
==========================================
- Hits 138113 138098 -15
- Misses 56999 57097 +98
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tabVersion
reviewed
Mar 24, 2023
wenym1
reviewed
Mar 24, 2023
...tor-service/src/main/java/com/risingwave/connector/deserializer/StreamChunkDeserializer.java
Show resolved
Hide resolved
I will do it in following PR since I have little knowledgement of Java, It's better for me to keep it simple. |
adevday
force-pushed
the
idx0dev/java_bind
branch
from
ca363e0 to
c86c319
Compare
adevday
force-pushed
the
idx0dev/java_bind
branch
from
c86c319 to
e27e0e6
Compare
TennyZhuang
reviewed
Mar 28, 2023
TennyZhuang
reviewed
Mar 28, 2023
wenym1
reviewed
Mar 28, 2023
src/java_binding/src/lib.rs
Outdated
| idx: jint, | ||
| ) -> JObject<'a> { | ||
| // since JMethodID is always validate until the belonging class is unload. | ||
| static INIT_METHOD: OnceCell<JMethodID> = OnceCell::new(); |
adevday
force-pushed
the
idx0dev/java_bind
branch
from
1b1b144 to
1247954
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
7 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add timestamp & decimal type support to java bindings.
Checklist For Contributors
./risedev check(or alias,./risedev c)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note