Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(executor, frontend): Lookup join should not have unaligned eq keys #8402

Merged
merged 3 commits into from
Mar 8, 2023

Conversation

jon-chuang
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Lookup join should not have unaligned eq keys

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR DOES NOT contain user-facing changes.

Related

Fixes part of: #7334

@github-actions github-actions bot added the type/fix Bug fix label Mar 7, 2023
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jon-chuang jon-chuang enabled auto-merge March 8, 2023 02:04
@jon-chuang jon-chuang added this pull request to the merge queue Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #8402 (4bbd8a8) into main (52c868c) will increase coverage by 0.00%.
The diff coverage is 14.28%.

@@           Coverage Diff           @@
##             main    #8402   +/-   ##
=======================================
  Coverage   71.58%   71.58%           
=======================================
  Files        1135     1135           
  Lines      185118   185113    -5     
=======================================
+ Hits       132514   132515    +1     
+ Misses      52604    52598    -6     
Flag Coverage Δ
rust 71.58% <14.28%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...batch/src/executor/join/distributed_lookup_join.rs 0.00% <0.00%> (ø)
src/batch/src/executor/join/local_lookup_join.rs 54.80% <0.00%> (+0.29%) ⬆️
...ntend/src/optimizer/plan_node/batch_lookup_join.rs 62.67% <100.00%> (+0.17%) ⬆️
src/storage/src/hummock/compactor/mod.rs 80.57% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 370286e Mar 8, 2023
@jon-chuang jon-chuang deleted the jon/enforce-type-alignment branch March 8, 2023 02:27
stdrc pushed a commit that referenced this pull request Mar 8, 2023
@jon-chuang jon-chuang mentioned this pull request Mar 8, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants