-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meta): improve param updating process when the cluster version upgrades #8260
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8260 +/- ##
==========================================
- Coverage 71.57% 71.57% -0.01%
==========================================
Files 1130 1130
Lines 184096 184098 +2
==========================================
- Hits 131771 131766 -5
- Misses 52325 52332 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM.
$macro /* Define future deprecated params here, such as | ||
* ,{ backup_storage_directory, String, "backup".to_string() } */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really works but seems a little bit strange to pass deprecated params to the macro of undeprecated_params
. 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really can't think of another way to put two for_all_xxx
mcros together 😢
f81000a
to
3c8ded6
Compare
Hey @Gun9niR, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
When the RW cluster upgrades to a new version, new parameters may be introduced. They may either be:
For the first case,
SystemParamManager
will detect missing params and initialize them with CLI values or default values.For the second case, a framework is added to conveniently derive the value of new params with existing params. The developer simply needs to override the trait
OverrideFromParams
to define custom rules.Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note