-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqlparser): align operator precedence with PostgreSQL #8174
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8174 +/- ##
==========================================
- Coverage 71.85% 71.84% -0.01%
==========================================
Files 1129 1129
Lines 181263 181272 +9
==========================================
+ Hits 130239 130241 +2
- Misses 51024 51031 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work 🤯
Hey @xiangjinwu, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach is much more clear 👍 thanks for this!
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Follow the operator precedence specified by PostgreSQL:
https://www.postgresql.org/docs/current/sql-syntax-lexical.html#SQL-PRECEDENCE
xor
,==
,<=>
,!
Fixes #8140
Related: #7665
Checklist For Contributors
./risedev check
(or alias,./risedev c
)Documentation