Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): display distinct dedup tables in dashboard #7948

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Feb 15, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

@github-actions github-actions bot added the type/fix Bug fix label Feb 15, 2023
@stdrc stdrc requested a review from BugenZhao February 15, 2023 09:00
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #7948 (764c52b) into main (2541ec6) will increase coverage by 0.00%.
The diff coverage is 23.07%.

@@           Coverage Diff           @@
##             main    #7948   +/-   ##
=======================================
  Coverage   71.69%   71.69%           
=======================================
  Files        1116     1116           
  Lines      179341   179364   +23     
=======================================
+ Hits       128571   128589   +18     
- Misses      50770    50775    +5     
Flag Coverage Δ
rust 71.69% <23.07%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/stream/stream_graph/visit.rs 54.38% <20.00%> (-3.71%) ⬇️
...rc/optimizer/plan_node/stream_global_simple_agg.rs 74.19% <25.00%> (-4.88%) ⬇️
...rontend/src/optimizer/plan_node/stream_hash_agg.rs 77.00% <25.00%> (-4.73%) ⬇️
src/storage/src/hummock/sstable_store.rs 65.31% <0.00%> (+0.15%) ⬆️
src/storage/src/hummock/compactor/mod.rs 80.88% <0.00%> (+0.19%) ⬆️
src/storage/src/hummock/compactor/iterator.rs 98.24% <0.00%> (+0.29%) ⬆️
src/object_store/src/object/mem.rs 87.25% <0.00%> (+0.38%) ⬆️
src/batch/src/executor/group_top_n.rs 74.70% <0.00%> (+6.47%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stdrc stdrc requested a review from st1page February 15, 2023 09:17
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -93,6 +93,9 @@ where
always!(s.table, "HashAgg");
}
}
for (distinct_col, dedup_table) in &mut node.distinct_dedup_tables {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How could it work without assigning a global table ID before this PR? 🥵

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't show up in the dashboard and seems no other place will access the table id (

Copy link
Member

@BugenZhao BugenZhao Feb 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the table ID is local for each fragment graph (mview), then tables from multiple views may get conflicted. (note that we use the table id as the storage prefix) 😄 I guess it'll be better to assign a range, for example, from 1000, for global table IDs, then we can check it out earlier. Not a big deal.

@mergify mergify bot merged commit ff6db4a into main Feb 15, 2023
@mergify mergify bot deleted the rc/display-dedup-tables-in-dashboard branch February 15, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants