Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): avoid panic when multiple nodes configure bucket lifecycle rule simultaneously #7930

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

Gun9niR
Copy link
Contributor

@Gun9niR Gun9niR commented Feb 14, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title. The aws client already retries, so a temporary workaround before meta knows about state store before the next release is to print a warning message instead of panic.

@Gun9niR Gun9niR requested a review from hzxa21 February 14, 2023 15:10
@github-actions github-actions bot added the type/fix Bug fix label Feb 14, 2023
@Gun9niR Gun9niR force-pushed the zhidong/fix-bucket-lifecycle branch 4 times, most recently from 72f6c35 to 6251ee1 Compare February 15, 2023 05:40
@Gun9niR Gun9niR force-pushed the zhidong/fix-bucket-lifecycle branch from 6251ee1 to d8370c1 Compare February 15, 2023 05:41
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #7930 (566e454) into main (2cbb8e3) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #7930   +/-   ##
=======================================
  Coverage   71.70%   71.71%           
=======================================
  Files        1119     1119           
  Lines      178877   178871    -6     
=======================================
+ Hits       128264   128275   +11     
+ Misses      50613    50596   -17     
Flag Coverage Δ
rust 71.71% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/object_store/src/object/s3.rs 3.59% <0.00%> (+0.04%) ⬆️
src/object_store/src/object/mem.rs 86.87% <0.00%> (-0.39%) ⬇️
src/storage/src/hummock/compactor/iterator.rs 97.95% <0.00%> (-0.30%) ⬇️
src/storage/src/hummock/sstable_store.rs 65.16% <0.00%> (ø)
src/common/src/cache.rs 97.26% <0.00%> (+0.10%) ⬆️
src/object_store/src/object/mod.rs 51.40% <0.00%> (+0.21%) ⬆️
src/batch/src/executor/group_top_n.rs 74.70% <0.00%> (+6.47%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants