Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(log): suppress unnecessary warning #7676

Merged
merged 2 commits into from
Feb 3, 2023
Merged

chore(log): suppress unnecessary warning #7676

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe88119
chore(log): suppress unnecessary warning
zwang28 Feb 3, 2023
789ccdb
Merge branch 'main' into wangzheng/chore_log
mergify[bot] Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/storage/src/hummock/iterator/merge_inner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ use std::future::Future;
use std::ops::{Deref, DerefMut};

use risingwave_hummock_sdk::key::{FullKey, TableKey, UserKey};
use tracing::warn;

use crate::hummock::iterator::{DirectionEnum, HummockIterator, HummockIteratorDirection};
use crate::hummock::value::HummockValue;
Expand Down Expand Up @@ -261,7 +260,9 @@ impl<'a, T: Ord> Drop for PeekMutGuard<'a, T> {
/// call `PeekMut::pop` on the `PeekMut` and recycle the node to the unused list.
fn drop(&mut self) {
if let Some(peek) = self.peek.take() {
warn!("PeekMut are dropped without used. May be caused by future cancellation");
tracing::debug!(
"PeekMut are dropped without used. May be caused by future cancellation"
);
let top = PeekMut::pop(peek);
self.unused.push_back(top);
}
Expand Down