Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sqlsmith): reproduce 7218 #7366

Closed
wants to merge 3 commits into from
Closed

test(sqlsmith): reproduce 7218 #7366

wants to merge 3 commits into from

Conversation

kwannoel
Copy link
Contributor

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

This section will be used as the commit message. Please do not leave this empty!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

#7218

@github-actions github-actions bot added the component/test Test related issue. label Jan 13, 2023
@kwannoel kwannoel force-pushed the kwannoel/repro-7218 branch from 94a886c to 7f4ee01 Compare January 13, 2023 02:59
@BowenXiao1999
Copy link
Contributor

Seems no log 🤔

@BowenXiao1999 BowenXiao1999 self-requested a review January 13, 2023 03:55
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #7366 (582c758) into main (d574b49) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7366   +/-   ##
=======================================
  Coverage   73.05%   73.05%           
=======================================
  Files        1069     1069           
  Lines      171425   171425           
=======================================
+ Hits       125232   125242   +10     
+ Misses      46193    46183   -10     
Flag Coverage Δ
rust 73.05% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/object_store/src/object/mod.rs 51.51% <0.00%> (+0.21%) ⬆️
src/common/src/cache.rs 97.53% <0.00%> (+0.22%) ⬆️
src/meta/src/manager/cluster.rs 77.11% <0.00%> (+0.24%) ⬆️
src/storage/src/hummock/compactor/iterator.rs 98.25% <0.00%> (+0.29%) ⬆️
src/storage/src/hummock/sstable_store.rs 65.00% <0.00%> (+0.31%) ⬆️
src/object_store/src/object/mem.rs 87.50% <0.00%> (+0.75%) ⬆️
src/source/src/row_id.rs 92.13% <0.00%> (+1.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review.

@kwannoel kwannoel closed this Mar 15, 2023
@kwannoel kwannoel deleted the kwannoel/repro-7218 branch March 15, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants