Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Add StreamEnvironment to StreamFragmentGraph/TableFragments, display timezone in pg_matviews #7357

Merged
merged 54 commits into from
Jan 13, 2023

Conversation

jon-chuang
Copy link
Contributor

@jon-chuang jon-chuang commented Jan 12, 2023

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add StreamEnvironment to StreamFragmentGraph/TableFragments, display timezone in pg_matviews

Useful for user to check and for us to inspect the timezone used when defining the matview.

Example:

select * from pg_catalog.pg_matviews;

 schemaname | matviewname | matviewowner |                    definition                    | matviewid | matviewtimezone | ...
 public     | mv          |            1 | CREATE MATERIALIZED VIEW mv AS SELECT * FROM t1  |      1002 | UTC                  | ...
 public     | mv2         |            1 | CREATE MATERIALIZED VIEW mv2 AS SELECT * FROM t1 |      1003 | Asia/Singapore | ...

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#7337

@jon-chuang jon-chuang changed the title feat(frontend): Add timezone to TableCatalog properties for MVs, display in pg_matviews feat(frontend): Add StreamEnvironment to StreamFragmentGraph/TableFragments for MVs, display timezone in pg_matviews Jan 13, 2023
@jon-chuang jon-chuang changed the title feat(frontend): Add StreamEnvironment to StreamFragmentGraph/TableFragments for MVs, display timezone in pg_matviews feat(frontend): Add StreamEnvironment to StreamFragmentGraph/TableFragments, display timezone in pg_matviews Jan 13, 2023
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #7357 (b1ed9b3) into main (ae9d16e) will increase coverage by 0.00%.
The diff coverage is 66.03%.

@@           Coverage Diff           @@
##             main    #7357   +/-   ##
=======================================
  Coverage   73.07%   73.08%           
=======================================
  Files        1069     1069           
  Lines      171687   171732   +45     
=======================================
+ Hits       125461   125503   +42     
- Misses      46226    46229    +3     
Flag Coverage Δ
rust 73.08% <66.03%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntend/src/catalog/system_catalog/pg_catalog/mod.rs 0.00% <0.00%> (ø)
src/meta/src/rpc/service/ddl_service.rs 3.06% <0.00%> (-0.02%) ⬇️
src/meta/src/rpc/service/stream_service.rs 18.96% <0.00%> (-0.34%) ⬇️
src/meta/src/model/stream.rs 62.94% <75.00%> (+0.73%) ⬆️
src/frontend/src/handler/create_mv.rs 94.88% <100.00%> (+0.07%) ⬆️
src/frontend/src/optimizer/optimizer_context.rs 88.23% <100.00%> (+0.35%) ⬆️
...tend/src/stream_fragmenter/graph/fragment_graph.rs 96.87% <100.00%> (+0.04%) ⬆️
...ta/src/hummock/manager/compaction_group_manager.rs 74.54% <100.00%> (+0.06%) ⬆️
src/meta/src/stream/stream_manager.rs 69.84% <100.00%> (+0.06%) ⬆️
src/meta/src/stream/test_fragmenter.rs 99.28% <100.00%> (+<0.01%) ⬆️
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit 7bad62a into main Jan 13, 2023
@mergify mergify bot deleted the jon/timezone-in-mv-catalog branch January 13, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants