Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Make PgResponse session-timezone aware for batch and stream #7356

Merged
merged 51 commits into from
Jan 13, 2023

Conversation

jon-chuang
Copy link
Contributor

@jon-chuang jon-chuang commented Jan 12, 2023

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Make PgResponse session-timezone aware for batch and stream

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).
  • All checks passed in ./risedev check (or alias, ./risedev c)

Types of user-facing changes

Timestamp with time zone type will now be displayed with the session timezone.

Refer to a related PR or issue link (optional)

#7336

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #7356 (148b391) into main (7bad62a) will increase coverage by 0.00%.
The diff coverage is 73.07%.

@@           Coverage Diff           @@
##             main    #7356   +/-   ##
=======================================
  Coverage   73.07%   73.08%           
=======================================
  Files        1069     1069           
  Lines      171732   171777   +45     
=======================================
+ Hits       125500   125538   +38     
- Misses      46232    46239    +7     
Flag Coverage Δ
rust 73.08% <73.07%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/handler/query.rs 18.57% <0.00%> (-0.21%) ⬇️
src/frontend/src/handler/util.rs 83.33% <76.00%> (-1.99%) ⬇️
src/batch/src/task/task_execution.rs 53.78% <0.00%> (-0.53%) ⬇️
src/common/src/types/ordered_float.rs 31.05% <0.00%> (-0.20%) ⬇️
src/storage/src/hummock/compactor/mod.rs 83.63% <0.00%> (+0.15%) ⬆️
src/storage/src/hummock/sstable_store.rs 64.84% <0.00%> (+0.15%) ⬆️
src/common/src/cache.rs 97.53% <0.00%> (+0.22%) ⬆️
src/meta/src/manager/cluster.rs 77.11% <0.00%> (+0.24%) ⬆️
src/object_store/src/object/mem.rs 87.50% <0.00%> (+0.37%) ⬆️
src/object_store/src/object/mod.rs 51.51% <0.00%> (+0.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 092be23 into main Jan 13, 2023
@mergify mergify bot deleted the jon/pg-response-session-timezone-aware branch January 13, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants