Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stream group topn used wrong types for hash key #7326

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jan 11, 2023

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #7276

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

@xxchan xxchan requested review from st1page and wcy-fdu January 11, 2023 16:34
@github-actions github-actions bot added the type/fix Bug fix label Jan 11, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #7326 (3421b21) into main (21775bc) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #7326   +/-   ##
=======================================
  Coverage   73.05%   73.05%           
=======================================
  Files        1069     1069           
  Lines      170996   170999    +3     
=======================================
+ Hits       124918   124922    +4     
+ Misses      46078    46077    -1     
Flag Coverage Δ
rust 73.05% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/from_proto/group_top_n.rs 0.00% <0.00%> (ø)
src/storage/src/hummock/sstable/bloom.rs 96.59% <0.00%> (-2.28%) ⬇️
...rc/storage/hummock_sdk/src/filter_key_extractor.rs 92.32% <0.00%> (-0.26%) ⬇️
src/stream/src/executor/aggregation/minput.rs 96.49% <0.00%> (+0.10%) ⬆️
src/storage/src/hummock/compactor/mod.rs 83.63% <0.00%> (+0.15%) ⬆️
src/common/src/cache.rs 97.54% <0.00%> (+0.22%) ⬆️
src/batch/src/task/task_execution.rs 54.30% <0.00%> (+0.52%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 66.31% <0.00%> (+0.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@mergify mergify bot merged commit e875756 into main Jan 12, 2023
@mergify mergify bot deleted the xxchan/concrete-platypus branch January 12, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stream group topn panics when group by timestamp
2 participants