Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): start follower svc if follower node #6792

Merged
merged 61 commits into from
Dec 16, 2022

Conversation

CAJan93
Copy link
Contributor

@CAJan93 CAJan93 commented Dec 7, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

#6752

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

@CAJan93
Copy link
Contributor Author

CAJan93 commented Dec 7, 2022

Removing unittest since test was added to handle a panic that I removed (see #3435 and #3398)

@CAJan93 CAJan93 marked this pull request as ready for review December 7, 2022 14:58
…o feat_introduce_leader_and_standby_status_for_meta
@CAJan93 CAJan93 changed the title start follower svc if follower node feat(meta): start follower svc if follower node Dec 8, 2022
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #6792 (486bd34) into main (bf87df6) will decrease coverage by 0.43%.
The diff coverage is 50.66%.

@@            Coverage Diff             @@
##             main    #6792      +/-   ##
==========================================
- Coverage   73.16%   72.72%   -0.44%     
==========================================
  Files        1035     1036       +1     
  Lines      165574   166052     +478     
==========================================
- Hits       121141   120762     -379     
- Misses      44433    45290     +857     
Flag Coverage Δ
rust 72.72% <50.66%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/rpc/server.rs 0.00% <0.00%> (-79.55%) ⬇️
src/meta/src/rpc/elections.rs 57.99% <57.99%> (ø)
src/meta/src/hummock/mod.rs 22.22% <0.00%> (-74.61%) ⬇️
src/common/src/monitor/process_linux.rs 0.00% <0.00%> (-60.30%) ⬇️
src/meta/src/manager/idle.rs 56.97% <0.00%> (-31.40%) ⬇️
src/meta/src/rpc/intercept.rs 0.00% <0.00%> (-29.42%) ⬇️
src/meta/src/rpc/service/health_service.rs 0.00% <0.00%> (-27.28%) ⬇️
src/meta/src/model/user.rs 75.00% <0.00%> (-25.00%) ⬇️
src/meta/src/rpc/service/stream_service.rs 0.00% <0.00%> (-19.30%) ⬇️
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…o feat_introduce_leader_and_standby_status_for_meta
@CAJan93 CAJan93 requested a review from yezizp2012 December 9, 2022 10:18
@CAJan93 CAJan93 self-assigned this Dec 9, 2022
@yezizp2012 yezizp2012 requested a review from shanicky December 9, 2022 10:48
…o feat_introduce_leader_and_standby_status_for_meta
@CAJan93
Copy link
Contributor Author

CAJan93 commented Dec 12, 2022

The development work here is done. Deleting the unittest is ok IMHO, since it tests for a panic that we no longer throw. Please let me know what you think.

…o feat_introduce_leader_and_standby_status_for_meta
…o feat_introduce_leader_and_standby_status_for_meta
…sh://github.com/risingwavelabs/risingwave into feat_introduce_leader_and_standby_status_for_meta
}

#[tokio::test]
async fn follower_cannot_renew_lease() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should works and I tried locally. Uses MetaResult for all function in this crate if needed.

@CAJan93
Copy link
Contributor Author

CAJan93 commented Dec 15, 2022

It should works and I tried locally. Uses MetaResult for all function in this crate if needed.

Yes, I agree. I have MetaResult as a return type now for all functions except of get_leader_lease_obj and gen_rand_lease_id

@CAJan93
Copy link
Contributor Author

CAJan93 commented Dec 15, 2022

All checks pass, except of code coverage. IMHO this is ok. I will deliver more checks in the future. I believe that they are not really meaningful here, because this branch barely supports any features that we want to test (see test issue and tracking issue). What do you think @yezizp2012

@yezizp2012
Copy link
Member

All checks pass, except of code coverage. IMHO this is ok. I will deliver more checks in the future. I believe that they are not really meaningful here, because this branch barely supports any features that we want to test (see test issue and tracking issue). What do you think @yezizp2012

That's okay, forget about the code coverage now.

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, generally LGTM.

@mergify mergify bot merged commit 9c9075b into main Dec 16, 2022
@mergify mergify bot deleted the feat_introduce_leader_and_standby_status_for_meta branch December 16, 2022 10:07
@CAJan93
Copy link
Contributor Author

CAJan93 commented Dec 16, 2022

OMG, can't believe that this one is finally done. Thank you very much for you help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants