-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meta): start follower svc if follower node #6792
feat(meta): start follower svc if follower node #6792
Conversation
…o feat_introduce_leader_and_standby_status_for_meta
…o feat_introduce_leader_and_standby_status_for_meta
…o feat_introduce_leader_and_standby_status_for_meta
…o feat_introduce_leader_and_standby_status_for_meta
Codecov Report
@@ Coverage Diff @@
## main #6792 +/- ##
==========================================
- Coverage 73.16% 72.72% -0.44%
==========================================
Files 1035 1036 +1
Lines 165574 166052 +478
==========================================
- Hits 121141 120762 -379
- Misses 44433 45290 +857
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…o feat_introduce_leader_and_standby_status_for_meta
…o feat_introduce_leader_and_standby_status_for_meta
The development work here is done. Deleting the unittest is ok IMHO, since it tests for a panic that we no longer throw. Please let me know what you think. |
Co-authored-by: August <[email protected]>
…o feat_introduce_leader_and_standby_status_for_meta
…o feat_introduce_leader_and_standby_status_for_meta
…sh://github.com/risingwavelabs/risingwave into feat_introduce_leader_and_standby_status_for_meta
} | ||
|
||
#[tokio::test] | ||
async fn follower_cannot_renew_lease() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should works and I tried locally. Uses MetaResult
for all function in this crate if needed.
…o feat_introduce_leader_and_standby_status_for_meta
Yes, I agree. I have |
…o feat_introduce_leader_and_standby_status_for_meta
All checks pass, except of code coverage. IMHO this is ok. I will deliver more checks in the future. I believe that they are not really meaningful here, because this branch barely supports any features that we want to test (see test issue and tracking issue). What do you think @yezizp2012 |
That's okay, forget about the code coverage now. |
…o feat_introduce_leader_and_standby_status_for_meta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, generally LGTM.
OMG, can't believe that this one is finally done. Thank you very much for you help. |
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
#6752
./risedev check
(or alias,./risedev c
)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)