-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meta): Failover handling meta service #6466
Conversation
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
…o jm/multi-meta-etcd-grafana
Codecov Report
@@ Coverage Diff @@
## main #6466 +/- ##
==========================================
+ Coverage 73.20% 73.25% +0.04%
==========================================
Files 1024 1023 -1
Lines 163741 163598 -143
==========================================
- Hits 119870 119844 -26
+ Misses 43871 43754 -117
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
if was_leader { | ||
// && !is_leader { | ||
// TODO: enable this again to give leader chance to claim lease again? | ||
panic!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fencing mechanism
…o jm/multi-meta-etcd-grafana
…o jm/multi-meta-etcd-grafana
…o jm/multi-meta-etcd-grafana
…o jm/multi-meta-etcd-grafana
…o jm/multi-meta-etcd-grafana
Besides, Why are you maintaining this PR now? 🤔 |
I am keeping this PR more or less up to date to test how the current implementations work with the other things we will implement. Furthermore I am using this PR to copy paste things from into the new PRs. Totally agree with you. Only keeping this PR around for myself. We will not merge it and I am focusing on the actual feature PRs and not on this one. |
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
TODOs:
Checklist
./risedev check
(or alias,./risedev c
)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
#5943
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)