-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: health check RPC for compute node #6334
feat: health check RPC for compute node #6334
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6334 +/- ##
==========================================
- Coverage 74.36% 74.29% -0.07%
==========================================
Files 955 960 +5
Lines 156183 156525 +342
==========================================
+ Hits 116143 116288 +145
- Misses 40040 40237 +197
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What are the next steps required to merge this?
…On Mon, Nov 14, 2022 at 3:38 AM Wallace ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM
—
Reply to this email directly, view it on GitHub
<#6334 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALJF7XOLERQG24YUC3WB6LWIGQZ3ANCNFSM6AAAAAAR5TTGCQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
No worries, just tag the Thanks for the contribution! |
Hey @florissmit10, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with |
@lmatz Can you investigate this? |
seems okay now |
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR adds RPC health checks to the compute node and adresses this issue: #5070
I duplicated parts of the related PR because the health checking logic will most likely vary for each component when a more detailed implementation is made.
Checklist
./risedev check
(or alias,./risedev c
)