Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: health check RPC for compute node #6334

Merged

Conversation

florissmit10
Copy link
Contributor

@florissmit10 florissmit10 commented Nov 11, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR adds RPC health checks to the compute node and adresses this issue: #5070

I duplicated parts of the related PR because the health checking logic will most likely vary for each component when a more detailed implementation is made.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #6334 (1215d21) into main (afd39fe) will decrease coverage by 0.06%.
The diff coverage is 59.58%.

@@            Coverage Diff             @@
##             main    #6334      +/-   ##
==========================================
- Coverage   74.36%   74.29%   -0.07%     
==========================================
  Files         955      960       +5     
  Lines      156183   156525     +342     
==========================================
+ Hits       116143   116288     +145     
- Misses      40040    40237     +197     
Flag Coverage Δ
rust 74.29% <59.58%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...batch/src/executor/join/distributed_lookup_join.rs 0.00% <ø> (ø)
src/batch/src/executor/join/local_lookup_join.rs 56.28% <ø> (ø)
src/batch/src/executor/row_seq_scan.rs 54.24% <ø> (ø)
src/batch/src/executor/sys_row_seq_scan.rs 0.00% <ø> (ø)
src/batch/src/lib.rs 100.00% <ø> (ø)
src/common/src/array/data_chunk.rs 97.30% <ø> (ø)
src/common/src/array/data_chunk_iter.rs 86.36% <ø> (+2.47%) ⬆️
src/common/src/array/mod.rs 88.79% <ø> (ø)
src/common/src/array/stream_chunk.rs 87.45% <ø> (ø)
src/common/src/catalog/mod.rs 71.42% <ø> (ø)
... and 115 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@florissmit10
Copy link
Contributor Author

florissmit10 commented Nov 15, 2022 via email

@lmatz
Copy link
Contributor

lmatz commented Nov 15, 2022

What are the next steps required to merge this?

On Mon, Nov 14, 2022 at 3:38 AM Wallace @.> wrote: @.* approved this pull request. LGTM — Reply to this email directly, view it on GitHub <#6334 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALJF7XOLERQG24YUC3WB6LWIGQZ3ANCNFSM6AAAAAAR5TTGCQ . You are receiving this because you authored the thread.Message ID: @.***>

No worries, just tag the mergify/can-merge label to the PR,
the bot will update this branch based on main branch and then merge automatically if no tests break.

Thanks for the contribution!

@mergify
Copy link
Contributor

mergify bot commented Nov 15, 2022

Hey @florissmit10, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with git commit --allow-empty -m "rerun" && git push.

@soundOfDestiny
Copy link
Contributor

@lmatz Can you investigate this?
Sorry for inconvenience.

@soundOfDestiny
Copy link
Contributor

@lmatz Can you investigate this?
Sorry for inconvenience.

seems okay now

@mergify mergify bot merged commit ddae931 into risingwavelabs:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants