fix: fix hummock snapshot release in batch local execution #5971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Prior to this PR, batch query in local execution mode will release the hummock snapshot before query execution, which can cause the read epoch to be expired when reading from state store during query execution.
This PR fixes the issue by releasing the hummock snapshot after query execution is completed. Note the this is different from what we did for batch query in distributed execution mode, in which the hummock snapshot is released immediately after all scan executors are scheduled before the completion of query execution. I think this is acceptable since batch query in local execution mode is supposed to be fast and shouldn't hold the hummock snapshot for too long.
Checklist
- [ ] I have added necessary unit tests and integration tests./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)
Fix #5711