fix(meta): pin & unpin snapshot for mview creation with correct order #5606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 2202 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 1063 | 1 | 1138 | 0 |
Click to see the invalid file list
- src/meta/src/barrier/snapshot.rs
Codecov Report
@@ Coverage Diff @@
## main #5606 +/- ##
=======================================
Coverage 74.24% 74.24%
=======================================
Files 915 916 +1
Lines 143288 143359 +71
=======================================
+ Hits 106379 106436 +57
- Misses 36909 36923 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/fix-create-mview-unpin
branch
from
defa449 to
04605fc
Compare
BugenZhao
commented
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As explained in #5592. This PR introduces a simple
SnapshotManagerfor pinning & unpinning the snapshot during mview creation.Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)