Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard-srv): support list sources #5098

Merged
merged 2 commits into from
Sep 5, 2022
Merged

feat(dashboard-srv): support list sources #5098

merged 2 commits into from
Sep 5, 2022

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Sep 5, 2022

Signed-off-by: xxchan [email protected]

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add new APIs to get more data out of the meta node.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

ref #4137

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #5098 (f12fc67) into main (e1cacf0) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5098      +/-   ##
==========================================
- Coverage   74.24%   74.21%   -0.04%     
==========================================
  Files         882      882              
  Lines      134937   134837     -100     
==========================================
- Hits       100182   100067     -115     
- Misses      34755    34770      +15     
Flag Coverage Δ
rust 74.21% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/error.rs 0.00% <ø> (ø)
src/batch/src/executor/generic_exchange.rs 41.52% <ø> (+0.14%) ⬆️
src/batch/src/executor/join/hash_join.rs 95.36% <ø> (ø)
src/batch/src/executor/join/lookup_join.rs 57.28% <ø> (+1.12%) ⬆️
src/batch/src/executor/monitor/stats.rs 66.01% <ø> (-8.99%) ⬇️
src/batch/src/executor/row_seq_scan.rs 17.67% <ø> (+0.66%) ⬆️
src/common/src/config.rs 64.46% <ø> (+0.29%) ⬆️
src/common/src/hash/key.rs 84.49% <ø> (-1.62%) ⬇️
src/common/src/types/interval.rs 81.33% <ø> (-1.18%) ⬇️
src/compute/src/server.rs 0.00% <ø> (ø)
... and 167 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit a14d883 into main Sep 5, 2022
@mergify mergify bot deleted the xxchan/list-source branch September 5, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants