Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fragmenter): assign table_id while translating stream nodes to prost #5086

Merged
merged 8 commits into from
Sep 5, 2022

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Sep 3, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • ToStreamProst -> StreamNode
  • Added the tree-to-graph state to StreamNode::to_prost_body and assign table id while we are generating the prost tree
  • Remove the method that assigns table id and relevant tests

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

See changelist -- I renamed a trait and changed its signature and that's all.

Release note

Move the assign-table-id logic to prost generation.

Refer to a related PR or issue link (optional)

#3684

@ice1000 ice1000 marked this pull request as ready for review September 5, 2022 18:23
@ice1000 ice1000 changed the title refactor(fragmenter): (do not merge, this is a draft created for running CI) refactor(fragmenter): assign table_id while translating stream nodes to prost Sep 5, 2022
@ice1000 ice1000 requested a review from st1page September 5, 2022 18:59
@ice1000 ice1000 mentioned this pull request Sep 5, 2022
3 tasks
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #5086 (78f7e2e) into main (e1cacf0) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5086      +/-   ##
==========================================
- Coverage   74.24%   74.22%   -0.02%     
==========================================
  Files         882      882              
  Lines      134937   134818     -119     
==========================================
- Hits       100182   100068     -114     
+ Misses      34755    34750       -5     
Flag Coverage Δ
rust 74.22% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/error.rs 0.00% <ø> (ø)
src/batch/src/executor/generic_exchange.rs 41.52% <ø> (+0.14%) ⬆️
src/batch/src/executor/join/hash_join.rs 95.36% <ø> (ø)
src/batch/src/executor/join/lookup_join.rs 57.28% <ø> (+1.12%) ⬆️
src/batch/src/executor/monitor/stats.rs 66.01% <ø> (-8.99%) ⬇️
src/batch/src/executor/row_seq_scan.rs 17.67% <ø> (+0.66%) ⬆️
src/common/src/config.rs 64.46% <ø> (+0.29%) ⬆️
src/common/src/hash/key.rs 84.49% <ø> (-1.62%) ⬇️
src/common/src/types/interval.rs 81.33% <ø> (-1.18%) ⬇️
src/compute/src/server.rs 0.00% <ø> (ø)
... and 164 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants