Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minstant elapsed do not panic on time goes backward #4668

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

BugenZhao
Copy link
Member

Signed-off-by: Bugen Zhao [email protected]

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title. By bumping the version of minstant to v0.1.2, the issue is fixed by tikv/minstant#24.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@BugenZhao BugenZhao requested review from skyzh and fuyufjh August 16, 2022 07:58
@github-actions github-actions bot added the type/fix Bug fix label Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #4668 (7ec94e7) into main (e88dd9a) will decrease coverage by 0.03%.
The diff coverage is 73.22%.

@@            Coverage Diff             @@
##             main    #4668      +/-   ##
==========================================
- Coverage   74.08%   74.04%   -0.04%     
==========================================
  Files         862      862              
  Lines      129157   130242    +1085     
==========================================
+ Hits        95685    96439     +754     
- Misses      33472    33803     +331     
Flag Coverage Δ
rust 74.04% <73.22%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/execution/grpc_exchange.rs 59.52% <0.00%> (-4.58%) ⬇️
src/batch/src/execution/local_exchange.rs 63.88% <0.00%> (-1.83%) ⬇️
src/batch/src/executor/row_seq_scan.rs 17.36% <0.00%> (ø)
src/common/src/types/chrono_wrapper.rs 87.57% <0.00%> (ø)
src/common/src/util/value_encoding/error.rs 0.00% <ø> (ø)
...c/compute/src/compute_observer/observer_manager.rs 0.00% <0.00%> (ø)
src/compute/src/server.rs 0.00% <0.00%> (ø)
src/ctl/src/cmd_impl/hummock/list_version.rs 0.00% <0.00%> (ø)
src/ctl/src/cmd_impl/hummock/sst_dump.rs 0.00% <0.00%> (ø)
src/expr/src/expr/expr_binary_nonnull.rs 84.00% <ø> (ø)
... and 125 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit c03fcb1 into main Aug 16, 2022
@mergify mergify bot deleted the bz/fix-minstant-elapsed-panic branch August 16, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: compute node panicked at minstant time goes backward
2 participants