fix(sqlparser): Display of ConnectionRef shall be valid SQL

[xiangjinwu]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Bug since #19270 (v2.2).

The expected syntax of secret includes a preceding secret keyword, while connection does not:

  foo = secret bar,
  connection = baz,

However, the Display was implemented incorrectly and persists the following invalid SQL in meta catalog:

  connection = connection baz,

Such invalid SQL in catalog makes ALTER TABLE impossible:

ERROR: Failed to execute the statement

Caused by these errors (recent errors listed first):
  1: unable to parse original table definition
  2: sql parser error: expected ',' or ')' after option definition, found: baz

This PR fixes this issue in both directions:

• Display no longer produces the redundant connection
• parse_sql tolerates the redundant connection from existing persisted items

Checklist

• I have written necessary rustdoc comments.
• I have added necessary unit tests and integration tests.
• I have added test labels as necessary.
• I have added fuzzing tests or opened an issue to track them.
• My PR contains breaking changes.
• My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
• My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

• My PR needs documentation updates.

Release note

[tabVersion]

thanks for your fix

[tabVersion]

sorry for that