Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(1.5.1, over window): fix range cache when some of order by and input stream key columns are in partition by columns #14046

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Dec 18, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Pre-cherry-pick #14045 to v1.5.1-rc.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Dec 18, 2023
@stdrc stdrc enabled auto-merge (squash) December 18, 2023 10:06
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v1.5.1-rc@c0f3182). Click here to learn what that means.

Additional details and impacted files
@@             Coverage Diff              @@
##             v1.5.1-rc   #14046   +/-   ##
============================================
  Coverage             ?   68.18%           
============================================
  Files                ?     1525           
  Lines                ?   262293           
  Branches             ?        0           
============================================
  Hits                 ?   178837           
  Misses               ?    83456           
  Partials             ?        0           
Flag Coverage Δ
rust 68.18% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stdrc stdrc merged commit 6da9617 into v1.5.1-rc Dec 18, 2023
@stdrc stdrc deleted the rc/fix-over-window-range-cache-cherrypick branch December 18, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants