-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ListArray support #1080
feat: ListArray support #1080
Conversation
The implementation of List and ListArray in the previous commit was merely a copy of Struct and StructArray. In this commit some methods of List and List are adjusted to their requirements
e10e0ae
to
d61e83a
Compare
The author of this PR, nanderstabel, is not an activated member of this organization on Codecov. |
Co-authored-by: Tao Wu <[email protected]>
Co-authored-by: Tao Wu <[email protected]>
Co-authored-by: Tao Wu <[email protected]>
With these latest changes this issue is ready to get merged (or else very close to being ready). Consideration:
This might not best solution in the future. |
What's changed and what's your intention?
Addition of
ListArray
to our list ofArray
types (#578 and #579). The intention was to use the already existing implementation ofStructArray
as a foundation and rewrite it to make it fit to the requirements as described here.Both
List<T>
andList<List<T>>
are supported.ListArrays
with different nested layersimpl
s forListRef
(many of them are still copy-pastes from their respectiveStructRef
counterparts)test_list_value_cmp
)Checklist