Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): add tracing for barrier commands & recovery #10694

Merged
merged 3 commits into from
Jul 4, 2023

Conversation

BugenZhao
Copy link
Member

Signed-off-by: Bugen Zhao [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#10000

Follow-up of #10660. This PR further adds tracing for the execution of barrier commands, and the recovery progress. RPC calls to compute node will be included as well.

Previews

  • DML with implicit FLUSH
    image
  • Create table
    image
  • Bootstrap recovery
    image

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

BugenZhao added 3 commits July 3, 2023 13:26
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao requested review from hzxa21 and yezizp2012 July 3, 2023 05:58
@github-actions github-actions bot added type/feature user-facing-changes Contains changes that are visible to users labels Jul 3, 2023
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BugenZhao BugenZhao removed the user-facing-changes Contains changes that are visible to users label Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #10694 (8273541) into main (4df5b21) will increase coverage by 0.00%.
The diff coverage is 65.41%.

@@           Coverage Diff           @@
##             main   #10694   +/-   ##
=======================================
  Coverage   70.23%   70.24%           
=======================================
  Files        1285     1285           
  Lines      219704   219738   +34     
=======================================
+ Hits       154311   154345   +34     
  Misses      65393    65393           
Flag Coverage Δ
rust 70.24% <65.41%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/lib.rs 0.00% <ø> (ø)
src/meta/src/manager/catalog/mod.rs 24.39% <ø> (ø)
src/meta/src/rpc/ddl_controller.rs 0.00% <0.00%> (ø)
src/meta/src/barrier/recovery.rs 52.69% <52.00%> (+0.11%) ⬆️
src/meta/src/barrier/schedule.rs 65.51% <79.31%> (+1.78%) ⬆️
src/meta/src/barrier/command.rs 37.37% <100.00%> (+0.30%) ⬆️
src/meta/src/barrier/mod.rs 83.79% <100.00%> (+0.49%) ⬆️
src/meta/src/manager/catalog/user.rs 95.06% <100.00%> (ø)
src/meta/src/stream/stream_manager.rs 75.28% <100.00%> (+0.07%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BugenZhao BugenZhao added this pull request to the merge queue Jul 4, 2023
Merged via the queue into main with commit c9b8bb5 Jul 4, 2023
@BugenZhao BugenZhao deleted the bz/meta-server-distributed-tracing branch July 4, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants