-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(batch): distributed tracing for batch queries #10637
Conversation
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
@@ -135,6 +136,7 @@ impl<C: BatchTaskContext> InnerSideExecutorBuilder<C> { | |||
}), | |||
}), | |||
epoch: Some(self.epoch.clone()), | |||
tracing_context: TracingContext::from_current_span().to_protobuf(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LocalLookupJoin
might cause a lot of tracing spans since it depends on the outer side's data size, but we have auto query mode which could reduce these cases by choosing the DistributedLookupJoin
, so LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will further introduce tracing in the frontend (handler) as the root span in next PRs.
LGTM! For batch queries, it would be great if we have a trace id that can connect all components. We can log the trace id into the query log as well.
Codecov Report
@@ Coverage Diff @@
## main #10637 +/- ##
==========================================
- Coverage 70.17% 70.15% -0.02%
==========================================
Files 1280 1280
Lines 220033 219965 -68
==========================================
- Hits 154413 154322 -91
- Misses 65620 65643 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Bugen Zhao [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Introduce distributed tracing for batch queries.
Will further introduce tracing in the frontend (handler) as the root span in next PRs.
Related: #10000, #10633, #10648.
Preview:
Checklist
./risedev check
(or alias,./risedev c
)