Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use alias as table function's column name (#10311) #10405

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Jun 19, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

- [ ] My PR contains user-facing changes.

@lmatz lmatz requested a review from xxchan June 19, 2023 09:59
@github-actions github-actions bot added type/fix Bug fix user-facing-changes Contains changes that are visible to users labels Jun 19, 2023
@lmatz lmatz removed the user-facing-changes Contains changes that are visible to users label Jun 19, 2023
@xxchan
Copy link
Member

xxchan commented Jun 19, 2023

Interesting. Why compilation failed.

@xxchan
Copy link
Member

xxchan commented Jun 19, 2023

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #10405 (60dc277) into v0.19.0-rc (767cb48) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@              Coverage Diff               @@
##           v0.19.0-rc   #10405      +/-   ##
==============================================
- Coverage       70.96%   70.96%   -0.01%     
==============================================
  Files            1231     1231              
  Lines          210978   210981       +3     
==============================================
+ Hits           149729   149731       +2     
- Misses          61249    61250       +1     
Flag Coverage Δ
rust 70.96% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/binder/relation/mod.rs 74.20% <75.00%> (-0.07%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lmatz
Copy link
Contributor Author

lmatz commented Jun 20, 2023

Thanks for the fix!

@lmatz lmatz merged commit fc9010f into v0.19.0-rc Jun 20, 2023
@lmatz lmatz deleted the 10311 branch June 20, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants