Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce distributed epoch-level tracing #10315

Merged
merged 28 commits into from
Jun 19, 2023
Merged
Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
145 changes: 138 additions & 7 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,6 @@ opt-level = 3
opt-level = 3
[profile.ci-dev.package."indextree"]
opt-level = 3
[profile.ci-dev.package."task_stats_alloc"]
opt-level = 3

# The profile used for deterministic simulation tests in CI.
# The simulator can only run single-threaded, so optimization is required to make the running time
Expand Down
2 changes: 1 addition & 1 deletion ci/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ steps:
config: ci/docker-compose.yml
mount-buildkite-agent: true
- ./ci/plugins/upload-failure-logs
timeout_in_minutes: 12
timeout_in_minutes: 15

- label: "end-to-end test for opendal (parallel)"
command: "ci/scripts/e2e-test-parallel-for-opendal.sh -p ci-dev"
Expand Down
2 changes: 1 addition & 1 deletion proto/stream_plan.proto
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ message Barrier {
ResumeMutation resume = 8;
}
// Used for tracing.
bytes span = 2;
map<string, string> tracing_context = 2;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never persist this message so it's okay.

// Whether this barrier do checkpoint
bool checkpoint = 9;

Expand Down
1 change: 1 addition & 0 deletions proto/stream_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ message InjectBarrierResponse {
message BarrierCompleteRequest {
string request_id = 1;
uint64 prev_epoch = 2;
map<string, string> tracing_context = 3;
}
message BarrierCompleteResponse {
message CreateMviewProgress {
Expand Down
27 changes: 21 additions & 6 deletions risedev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,18 @@ profile:

# If you want to use aws-s3, configure AK and SK in env var and enable the following lines:
# - use: aws-s3
# bucket: test-bucket
# bucket: test-bucket

# If you want to create CDC source table, uncomment the following line
# - use: connector-node

# if you want to enable etcd backend, uncomment the following lines.
# - use: etcd
# unsafe-no-fsync: true

# If you want to enable tracing, uncomment the following line.
# - use: jaeger

- use: meta-node
- use: compute-node
- use: frontend
Expand All @@ -43,9 +47,6 @@ profile:
# - use: prometheus
# - use: grafana

# If you want to enable tracing, uncomment the following line.
# - use: jaeger

# If you want to create source from Kafka, uncomment the following lines
# Note that kafka depends on zookeeper, so zookeeper must be started beforehand.
# - use: zookeeper
Expand Down Expand Up @@ -898,6 +899,9 @@ template:
# AWS s3 bucket used by the cluster
provide-aws-s3: "aws-s3*"

# Jaeger used by this meta node
provide-jaeger: "jaeger*"

# Whether to enable in-memory pure KV state backend
enable-in-memory-kv-state-backend: false

Expand Down Expand Up @@ -969,6 +973,9 @@ template:
# Meta-nodes used by this frontend instance
provide-meta-node: "meta-node*"

# Jaeger used by this frontend instance
provide-jaeger: "jaeger*"

# If `user-managed` is true, this service will be started by user with the above config
user-managed: false

Expand All @@ -991,9 +998,12 @@ template:
# Minio instances used by this compactor
provide-minio: "minio*"

# Meta-nodes used by this compute node
# Meta-nodes used by this compactor
provide-meta-node: "meta-node*"

# Jaeger used by this compator
provide-jaeger: "jaeger*"

# If `user-managed` is true, this service will be started by user with the above config
user-managed: false

Expand Down Expand Up @@ -1039,6 +1049,12 @@ template:
# Dashboard listen port of Jaeger
dashboard-port: 16680

# gRPC listen address of the OTLP collector
otlp-address: "127.0.0.1"

# gRPC listen port of the OTLP collector
otlp-port: 4317

# Jaeger has a lot of ports open, and we don't want to make this config more complex.
# So we keep the default value of jaeger instead of making it part of RiseDev config.

Expand All @@ -1064,7 +1080,6 @@ template:

# access key, secret key and region should be set in aws config (either by env var or .aws/config)


# Apache Kafka service
kafka:
# Id to be picked-up by services
Expand Down
Loading