-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add missing columns in information_schema.columns and add current_setting func #10269
Conversation
Codecov Report
@@ Coverage Diff @@
## main #10269 +/- ##
==========================================
+ Coverage 70.54% 70.59% +0.05%
==========================================
Files 1243 1243
Lines 212793 212860 +67
==========================================
+ Hits 150119 150277 +158
+ Misses 62674 62583 -91
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
src/frontend/src/catalog/system_catalog/information_schema/mod.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
To support golang ORM library 'xorm' and for grafana, this PR adds some missing columns in
information_schema.columns
, add acurrent_setting
function and fixes several issues.Related #10131 , #10134 . Resolve #10051 .
Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note
information_schema.columns
: column_default, character_maximum_length and udt_name.current_setting
.