Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing columns in information_schema.columns and add current_setting func #10269

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Jun 9, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

To support golang ORM library 'xorm' and for grafana, this PR adds some missing columns in information_schema.columns, add a current_setting function and fixes several issues.
Related #10131 , #10134 . Resolve #10051 .

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • SQL commands, functions, and operators

Release note

  1. add some missing columns in information_schema.columns: column_default, character_maximum_length and udt_name.
  2. add a new sql function: current_setting.

@github-actions github-actions bot added type/feature user-facing-changes Contains changes that are visible to users labels Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #10269 (fa1d089) into main (dd5c41b) will increase coverage by 0.05%.
The diff coverage is 41.79%.

@@            Coverage Diff             @@
##             main   #10269      +/-   ##
==========================================
+ Coverage   70.54%   70.59%   +0.05%     
==========================================
  Files        1243     1243              
  Lines      212793   212860      +67     
==========================================
+ Hits       150119   150277     +158     
+ Misses      62674    62583      -91     
Flag Coverage Δ
rust 70.59% <41.79%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/types/postgres_type.rs 15.09% <0.00%> (-3.96%) ⬇️
...c/catalog/system_catalog/information_schema/mod.rs 0.00% <0.00%> (ø)
src/frontend/src/binder/expr/function.rs 85.92% <63.15%> (-0.55%) ⬇️
src/common/src/session_config/mod.rs 62.82% <71.42%> (+29.33%) ⬆️
src/frontend/src/binder/mod.rs 90.50% <100.00%> (+0.32%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yezizp2012 yezizp2012 requested a review from xiangjinwu June 12, 2023 09:35
@yezizp2012 yezizp2012 added this pull request to the merge queue Jun 12, 2023
Merged via the queue into main with commit 5c5420c Jun 12, 2023
@yezizp2012 yezizp2012 deleted the zp/column-setting-etc branch June 12, 2023 11:15
@CharlieSYH CharlieSYH added the 📖✓ Covered or will be covered in the user docs. label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support current_setting
4 participants