-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sink): sink one-dimensional array data type to postgres and mysql #10032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 3526 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
1570 | 1 | 1955 | 0 |
Click to see the invalid file list
- java/connector-node/connector-api/src/main/java/com/risingwave/connector/api/ColumnDesc.java
java/connector-node/connector-api/src/main/java/com/risingwave/connector/api/ColumnDesc.java
Show resolved
Hide resolved
a26c062
to
4c7ba7c
Compare
4c7ba7c
to
46ad92b
Compare
78e3776
to
d98e4b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
java/connector-node/connector-api/src/main/java/com/risingwave/connector/api/TableSchema.java
Outdated
Show resolved
Hide resolved
java/connector-node/risingwave-sink-jdbc/src/main/java/com/risingwave/connector/JDBCSink.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #10032 +/- ##
==========================================
- Coverage 70.85% 70.82% -0.04%
==========================================
Files 1234 1234
Lines 211333 211410 +77
==========================================
- Hits 149741 149729 -12
- Misses 61592 61681 +89
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
870329a
to
c1dd758
Compare
Comments are fixed. PTAL again. @fuyufjh @tabVersion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Acceptable to me |
#10032) Co-authored-by: weili <[email protected]>
#10032) Co-authored-by: weili <[email protected]>
#10032) (#10514) Co-authored-by: StrikeW <[email protected]> Co-authored-by: weili <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
ARRAY['Value 1', 'Value 2']
will be converted toValue 1,Value 2
#9919
close #9918
Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note