feat(planner): match vector indexes #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyzh
force-pushed
the
skyzh/match-index
branch
from
e2a0a9e to
bf8b849
Compare
Signed-off-by: Alex Chi <[email protected]>
skyzh
force-pushed
the
skyzh/match-index
branch
from
bf8b849 to
8b422e3
Compare
Signed-off-by: Alex Chi <[email protected]>
Co-authored-by: Runji Wang <[email protected]> Signed-off-by: Alex Chi Z. <[email protected]>
Co-authored-by: Runji Wang <[email protected]> Signed-off-by: Alex Chi Z. <[email protected]>
Co-authored-by: Runji Wang <[email protected]> Signed-off-by: Alex Chi Z. <[email protected]>
|
Actually, vector index scan is different from index scan. The vector index scan operator has an However, I just realized that the op type can be inferred from the index type stored so we can remove it and make it generic. |
Signed-off-by: Alex Chi <[email protected]>
|
ready for review :) |
|
but there's still difference between index scan and vector index scan: for vector index scans, we need to provide a constant vector; for normal index scan, it's just the order by column |
|
let's use a single |
Signed-off-by: Alex Chi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for create index statements on vector columns and produces vector_index_scan plans. The executors are not implemented yet.