refactor: move to PevmChain::get_tx_env #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kien-rise
force-pushed
the
1540-refine-pevm-chain
branch
from
d668962 to
5e650f4
Compare
kien-rise
force-pushed
the
1540-refine-pevm-chain
branch
from
5e650f4 to
687fbe7
Compare
hai-rise
reviewed
Sep 5, 2024
hai-rise
reviewed
Sep 5, 2024
src/chain/ethereum.rs
Outdated
| impl PevmChain for PevmEthereum { | ||
| type Transaction = Transaction; |
There was a problem hiding this comment.
Rare place where we should add :: to be honest.
There was a problem hiding this comment.
Can you check again? I explicit write alloy_rpc_types::Transaction in this place and some more places.
hai-rise
reviewed
Sep 5, 2024
hai-rise
reviewed
Sep 5, 2024
hai-rise
reviewed
Sep 5, 2024
kien-rise
force-pushed
the
1540-refine-pevm-chain
branch
from
8b942b6 to
d0d67ed
Compare
hai-rise
reviewed
Sep 5, 2024
kien-rise
force-pushed
the
1540-refine-pevm-chain
branch
2 times, most recently
from
db736d0 to
892e86b
Compare
kien-rise
force-pushed
the
1540-refine-pevm-chain
branch
from
892e86b to
ab786ce
Compare
hai-rise
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #233 (comment)