WEB3-367: Install r0vm #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wollac
approved these changes
Mar 5, 2025
rust-toolchain.toml
Outdated
| @@ -1,5 +1,5 @@ | |||
| [toolchain] | |||
| channel = "1.81" | |||
| channel = "1.83" | |||
There was a problem hiding this comment.
I am really not a fan of this, as - especially for risc0-ethereum - it leads to super cryptic error messages, as alloy has already switched to rust 1.83, but all these crates are not (yet) supported in our ZKVM.
There was a problem hiding this comment.
Has been addressed in ab97318
Wollac
reviewed
Mar 5, 2025
| @@ -73,10 +78,15 @@ runs: | |||
| - name: install cargo-risczero from crates.io | |||
There was a problem hiding this comment.
Do we actually still need to install cargo-risczero at all? Hasn't it been completely replaced by rzup?
capossele
added a commit
that referenced
this pull request
Mar 5, 2025
In the cargo-risczero-install action, specifically the path using the version (rather than the ref) the r0vm installation was missing --------- Co-authored-by: Wolfgang Welz <[email protected]>
capossele
added a commit
that referenced
this pull request
Mar 5, 2025
In the cargo-risczero-install action, specifically the path using the version (rather than the ref) the r0vm installation was missing --------- Co-authored-by: Wolfgang Welz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the cargo-risczero-install action, specifically the path using the version (rather than the ref) the r0vm installation was missing