Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-hentai ripper not working fix. #209

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

joroto
Copy link

@joroto joroto commented Nov 19, 2024

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

Fixed changed selector for E-Hentai ripper

Testing

Manually downloaded a couple of galleries.

@Blehda
Copy link

Blehda commented Dec 1, 2024

Hello, New to Github just wondering if there is a fix available for this yet? Not super sure if I have add code or if there will a new .jar out soon fixing it.

@joroto
Copy link
Author

joroto commented Dec 1, 2024

@Blehda The fix is ready, but it has to be reviewed, approved and merged (basically the change accepted into the main code of the app). Then the owner creates a new release (new jar will be created yes, I think the app also can update itself through the menu).

Currently we are waiting on the owner to review the changes and apply them. This could take a while.

You could clone the branch (basically my copy of the project with the changes) here https://github.com/joroto/ripme/tree/E-hentai-ripper-not-working and build the jar with the changes yourself with ./gradlew clean build

@Blehda
Copy link

Blehda commented Dec 1, 2024

Ah I got it. I think I'll wait for the updated version to come out, I do 0 coding and have no experience with it. I really do appreciate your response! @joroto Thank you for the fixing the issue let's just hope the owner adds it soon

@soloturn soloturn merged commit e86161d into ripmeapp2:main Dec 13, 2024
0 of 4 checks passed
@joroto joroto deleted the E-hentai-ripper-not-working branch December 14, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E-hentai ripper not working
3 participants