Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coomer.party Ripper Add Next Page Download Functionality #204

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

AlanParsens
Copy link

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • [] a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix
  • a new feature

Description

The original coomer.party ripper never implemented anything beyond getting the first page, and with coomer.party seemingly on it's last legs, doing a quick fix to be able to rescue it's content seemed prudent.

This doesn't do much other than add the GetNextPage override, track the pagination, and cleans up the code so it wouldn't be repeated.

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@soloturn soloturn merged commit 91aeb37 into ripmeapp2:main Nov 3, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants