pyproject.toml #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active, please add a comment. This PR is labeled |
|
We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active or becomes active again, please reopen it. This PR was closed and archived because there has been no new activity in the 14 days since the |
rinarakaki
pushed a commit
that referenced
this pull request
Dec 29, 2024
On a Cortex-A55 this resulted in a 28.30% reduction in CPU and wall time for the binary search path.
Loop body before:
```
.LBB0_2:
add w8, w12, #1
cmp w8, w11
b.gt .LBB0_6 // Predictable branch, ends the loop
.LBB0_3:
add w12, w8, w11
add w12, w12, w12, lsr protocolbuffers#31
asr w12, w12, #1
smaddl x0, w12, w10, x9
ldr w13, [x0]
cmp w13, w1
b.lo .LBB0_2 // Unpredictable branch here! Will be hit 50/50 in prod
b.ls .LBB0_7 // Predictable branch - ends the loop
sub w11, w12, #1
cmp w8, w11
b.le .LBB0_3 // Predictable branch - continues the loop
```
Loop body after:
```
.LBB7_1:
cmp w9, w11
b.hi .LBB7_4 // Predictable branch - ends the loop
add w12, w9, w11
lsr w12, w12, #1
umaddl x0, w12, w8, x10
sub w14, w12, #1
ldr w13, [x0]
cmp w13, w1
csel w11, w14, w11, hs
csinc w9, w9, w12, hs
b.ne .LBB7_1 // Predictable branch - continues the loop
```
PiperOrigin-RevId: 703214356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.