This repository has been archived by the owner on Feb 26, 2021. It is now read-only.
Fix order of operations with ternary operations #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you paste example of final compiled code? |
done |
wielrls
previously approved these changes
Jul 30, 2019
wielrls
approved these changes
Jul 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes order of operations error when
ocwas combined with ternary operations.For example, previously,
would compile to,
which would evaluate to empty string because of the order of operations on the javascript ternary operator.
This PR fixes this with an additional set of parenthesis,
Test Plan
Test with new unit test and within the dependent codebase.
Compiled test code: