Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash by iteration on non-existing directory #837

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix: crash by iteration on non-existing directory #837

merged 1 commit into from
Mar 5, 2024

Conversation

fxliang
Copy link
Contributor

@fxliang fxliang commented Mar 5, 2024 •
edited
Loading

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

lotem
lotem requested changes Mar 5, 2024
View reviewed changes
src/rime/lever/deployment_tasks.cc Outdated Show resolved Hide resolved
@fxliang
Copy link
Contributor Author

fxliang commented Mar 5, 2024

squashed

@lotem lotem merged commit ec2d87d into rime:master Mar 5, 2024
9 checks passed
@fxliang fxliang deleted the fixcleanlog branch March 12, 2024 05:29
@fxliang fxliang mentioned this pull request Jun 7, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lotem lotem lotem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fxliang @lotem