Fix a potential race condition of MaybeCreateDirectory #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a directory is being created by two threads at the same time, it is possible that one succeed while the other fails. This change the order of create & check, so no matter which thread create the directory first, it will always succeed in the end.
groverlynn
pushed a commit
to groverlynn/librime
that referenced
this pull request
Sep 27, 2023
* Fix a potential race condition of MaybeCreateDirectory --------- Co-authored-by: Qijia Liu <[email protected]>
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Nov 2, 2023
* Fix a potential race condition of MaybeCreateDirectory --------- Co-authored-by: Qijia Liu <[email protected]>
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Nov 8, 2023
* Fix a potential race condition of MaybeCreateDirectory --------- Co-authored-by: Qijia Liu <[email protected]>
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Mar 18, 2024
* Fix a potential race condition of MaybeCreateDirectory --------- Co-authored-by: Qijia Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a directory is being created by two threads at the same time, it is possible that one succeed while the other fails. This change the order of create & check, so no matter which thread create the directory first, it will always succeed in the end.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #
Feature
Describe feature of pull request
Unit test
Manual test
Code Review
Additional Info