Replace boost filesystem with std filesystem #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lotem
reviewed
May 11, 2023
WhiredPlanck
force-pushed
the
filesystem
branch
10 times, most recently
from
d4f6a55 to
8afc383
Compare
|
@lotem 这个 PR 目前（我的）第一阶段工作已完成，等待审阅。 |
WhiredPlanck
force-pushed
the
filesystem
branch
from
a24e73c to
bfadceb
Compare
WhiredPlanck
force-pushed
the
filesystem
branch
from
bfadceb to
ef621be
Compare
WhiredPlanck
force-pushed
the
filesystem
branch
5 times, most recently
from
1b83688 to
6a50750
Compare
use UCRT64 as msystem, which is recommended by msys2.
WhiredPlanck
force-pushed
the
filesystem
branch
from
6a50750 to
a70d072
Compare
WhiredPlanck
force-pushed
the
filesystem
branch
from
62c1125 to
ea2544a
Compare
…dows ... ... before run actions/checkout to prevent potential problems from msys2. Ref: https://github.com/marketplace/actions/setup-msys2#actionscheckout-and-line-endings
WhiredPlanck
force-pushed
the
filesystem
branch
3 times, most recently
from
9cec845 to
5b6b481
Compare
WhiredPlanck
force-pushed
the
filesystem
branch
from
5b6b481 to
84a4123
Compare
WhiredPlanck
force-pushed
the
filesystem
branch
from
c4c6c8f to
1b2a467
Compare
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Nov 2, 2023
* chore: set default C++ standard as 17 * refactor: replace boost filesystem with std filesystem * build: remove boost filesystem component * feat: make boost dll use std filesystem * build(Makefile): raise MACOSX_DEPLOYMENT_TARGET to 10.15 * ci(windows-build.yml): improve msys2 setup use UCRT64 as msystem, which is recommended by msys2. * ci(windows-build.yml): use pre-installed msys2 * ci(windows-build.yml): disable git line ending auto conversion on Windows ... ... before run actions/checkout to prevent potential problems from msys2. Ref: https://github.com/marketplace/actions/setup-msys2#actionscheckout-and-line-endings * build(src/CMakeLists.txt): explicitly link bcrypt to fix build error with mingw64 * ci(Dockerfile): temporarily apply unmerged patch to verify build
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Nov 8, 2023
* chore: set default C++ standard as 17 * refactor: replace boost filesystem with std filesystem * build: remove boost filesystem component * feat: make boost dll use std filesystem * build(Makefile): raise MACOSX_DEPLOYMENT_TARGET to 10.15 * ci(windows-build.yml): improve msys2 setup use UCRT64 as msystem, which is recommended by msys2. * ci(windows-build.yml): use pre-installed msys2 * ci(windows-build.yml): disable git line ending auto conversion on Windows ... ... before run actions/checkout to prevent potential problems from msys2. Ref: https://github.com/marketplace/actions/setup-msys2#actionscheckout-and-line-endings * build(src/CMakeLists.txt): explicitly link bcrypt to fix build error with mingw64 * ci(Dockerfile): temporarily apply unmerged patch to verify build
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Nov 8, 2023
* chore: set default C++ standard as 17 * refactor: replace boost filesystem with std filesystem * build: remove boost filesystem component * feat: make boost dll use std filesystem * build(Makefile): raise MACOSX_DEPLOYMENT_TARGET to 10.15 * ci(windows-build.yml): improve msys2 setup use UCRT64 as msystem, which is recommended by msys2. * ci(windows-build.yml): use pre-installed msys2 * ci(windows-build.yml): disable git line ending auto conversion on Windows ... ... before run actions/checkout to prevent potential problems from msys2. Ref: https://github.com/marketplace/actions/setup-msys2#actionscheckout-and-line-endings * build(src/CMakeLists.txt): explicitly link bcrypt to fix build error with mingw64 * ci(Dockerfile): temporarily apply unmerged patch to verify build
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Mar 18, 2024
* chore: set default C++ standard as 17 * refactor: replace boost filesystem with std filesystem * build: remove boost filesystem component * feat: make boost dll use std filesystem * build(Makefile): raise MACOSX_DEPLOYMENT_TARGET to 10.15 * ci(windows-build.yml): improve msys2 setup use UCRT64 as msystem, which is recommended by msys2. * ci(windows-build.yml): use pre-installed msys2 * ci(windows-build.yml): disable git line ending auto conversion on Windows ... ... before run actions/checkout to prevent potential problems from msys2. Ref: https://github.com/marketplace/actions/setup-msys2#actionscheckout-and-line-endings * build(src/CMakeLists.txt): explicitly link bcrypt to fix build error with mingw64 * ci(Dockerfile): temporarily apply unmerged patch to verify build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes # N/A
Feature
Describe feature of pull request
Replace boost filesystem with std filesystem, since there is a filesystem library in the STL since C++17.
Unit test
Manual test
Code Review
Additional Info