Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace iRime with Hamster [skip ci] #642

Merged
merged 1 commit into from
Jun 11, 2023
Merged

Conversation

eagleoflqj
Copy link
Member

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

iRime stopped updating source code long time ago, so the version on App Store is proprietary.
Instead, Hamster is real open source and becoming popular.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@amorphobia
Copy link

iRime 的另外一个问题是:是否涉嫌违反 BSD 协议第三条——不可以用开源代码的作者/机构名字和原来产品的名字做市场推广

评价指出,iRime 内置了友盟+来追踪用户信息,由于 iRime 使用了 rime 来作为推广和背书,这可能会对 librime 的口碑有潜在影响。

@eagleoflqj
Copy link
Member Author

列入的时候还是开源的,而且佛振批了#119 ,所以名称问题应该不大
但是这个真的非常误导用户,我最初以为是开源的而且GitHub上也确实摆了个repo,跟请不要吸开源的血讲的情形如出一辙

@LEOYoon-Tsaw
Copy link
Member

它不繼續開源的話就失去了版權許可,可以向Apple投訴他侵權,讓他下架

@lotem lotem merged commit 77e8a5c into rime:master Jun 11, 2023
@eagleoflqj eagleoflqj deleted the hamster branch June 11, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants