feat: add lazy option to allow recalculating targets #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anybody is here? |
|
Should I update documentation? |
rigor789
reviewed
Oct 27, 2020
src/scrollTo.js
Outdated
Comment on lines
109
to
118
| if (x) { | ||
| targetX = | ||
| cumulativeOffsetElement.left - cumulativeOffsetContainer.left + offset | ||
| diffX = targetX - initialX | ||
| } | ||
| if (y) { | ||
| targetY = | ||
| cumulativeOffsetElement.top - cumulativeOffsetContainer.top + offset | ||
| diffY = targetY - initialY | ||
| } |
There was a problem hiding this comment.
I would refactor this since calculations are same as
Lines 196 to 207 in eb11b5f
Refactoring both places to use a function would likely be a cleaner approach - since if we ever need to change how the target is calculated, it needs to be done in a single spot.
Something like recalculateTargets, or something better perhaps.
There was a problem hiding this comment.
Should I do it or you will?
There was a problem hiding this comment.
I probably won't be able to for at least a few weeks, so if you are able to do it, that would be perfect!
rigor789
reviewed
Oct 28, 2020
rigor789
changed the title
|
🎉 This PR is included in version 2.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I ran into a problem when I was trying to use this lib on a dynamically growing container. Figuratively speaking, at the start of the scroll, the height of the container was 500px, and at the end it could reach 5000px. Thus, the initially set position was strongly shifted down, but the scrollTo did not know about this and scrolled to the wrong place. This PR solves this problem.