Rewrite the codebase to be high quality #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviews in this chain: |
This PR overhauls the codebase to move it from a hack to a proper foundation to build upon. Some of the changes: * Refactor code into modules and classes * More heavily lean on pydub as a great audio library * Introduce ruff, black, and mypy and make them pass * Test suite * Apple MPS support (with CPU fallback for unsupprted stuff) * Support stereo spectrogram images (prototype) * Support embedding parameters into image metadata as EXIF * Add tools for easily comparing parameters and running albations * Improve the readme Topic: clean_rewrite
Topic: clean_rewrite
Topic: clean_rewrite
Topic: clean_rewrite
Topic: clean_rewrite
This class is a helper to convert between spectrogram tensors and audio. Topic: clean_rewrite
This class converts between spectrogram images and audio. Uses SpectrogramConverter internally, which only deals with tensors. Topic: clean_rewrite
* Bunch of cleanup and typing * Move prompt_weighting to be marked as external * Add helpers for loading the checkpoint and traced unet Topic: clean_rewrite
No longer needed, it's broken up into cleaner pieces. Topic: clean_rewrite
With the new clean module structure, make it so the two servers share all the important code. This makes the baseten integration very small and simple, and paves the way for more integrations. Topic: clean_rewrite
* Adds a pyproject.toml * Update requirements and dev requirements * Add a CITATION file * Add details to the README Topic: clean_rewrite
Add riffusion.cli tool for common operations. Add a test for each one. Topic: clean_rewrite
This fels good! Topic: clean_rewrite
Topic: clean_rewrite
hmartiro
changed the title
hmartiro
force-pushed
the
hayk.mart/revup/main/clean_rewrite
branch
from
bb81078 to
d820e1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overhauls the codebase to move it from a hack to a proper
foundation to build upon.
Some of the changes:
Topic: clean_rewrite