Skip to content

Commit

Permalink
Fix a system test TODO (googleapis#3314)
Browse files Browse the repository at this point in the history
This should prevent the (as of yet, unexperienced) error case where
the API deletes the acked messages before we have a chance to seek
to them.
  • Loading branch information
geigerj authored and lukesneeringer committed Apr 19, 2017
1 parent d1c197e commit 8d9bb35
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pubsub/tests/system.py
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,8 @@ def test_seek(self):
self.to_delete.append(topic)

SUBSCRIPTION_NAME = 'subscribing-to-seek' + unique_resource_id('-')
subscription = topic.subscription(SUBSCRIPTION_NAME)
subscription = topic.subscription(
SUBSCRIPTION_NAME, retain_acked_messages=True)
self.assertFalse(subscription.exists())
subscription.create()
self.to_delete.append(subscription)
Expand Down

0 comments on commit 8d9bb35

Please sign in to comment.