Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
First of all: thank you for this project! Life & time saver.
I am using this middleware on several projects, and I have, on all of those project, the same problem:
The problem is:
I do not only upload files, but I also do some business transformation on them. As I try to keep everything as simple as possible: I just use your file object without decorator or anything else.
So, for the tests… it need many boilerplates or… a decorator…
This is why this pull request:
I would love to have a real FileObject / File or just a factory. I choose the factory option to keep this project also simple.
The steps are split on several commits. If you agree on the principe, I would like to talk about the last one: 64ff2b5
I've exposed the
fileFactory
, so people who want to use it can simply do:If you just want to replace it by:
Just ask.
To finish, as it is quite like a low level functionality, I don't think it should be documented, people who want to test it can find it easily by looking at this repository.
Thank you!