remove before check & always run replace emoticon if enabled

rhysd · Mar 17, 2020 · 8aa9eec · 8aa9eec
1 parent d25c4d1
commit 8aa9eec
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -37,10 +37,9 @@ function plugin(options) {
 
     function transformer(tree) {
         visit(tree, 'text', function(node) {
-            before = node.value;
-            node.value = before.replace(RE_EMOJI, getEmoji);
+            node.value = node.value.replace(RE_EMOJI, getEmoji);
 
-            if (emoticonEnable && node.value === before) {
+            if (emoticonEnable) {
                 // emoji regex not matching --> check if shortcode
                 node.value = node.value.replace(RE_SHORT, getEmojiByShortCode);
             }

diff --git a/index_test.js b/index_test.js
@@ -38,7 +38,7 @@ describe('remark-emoji', () => {
     it('does not replace emoji-like but not-a-emoji stuffs', () => {
         const cases = {
             'This text does not include emoji.': 'This text does not include emoji.\n',
-            ':++: or :foo: or :dog': ':++: or :foo: or :dog\n',
+            ':++: or :foo: or :cat': ':++: or :foo: or :cat\n',
             '::': '::\n'
         };