Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COO-526: disable events from the serving certificate controller #625

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

simonpasquier
Copy link
Contributor

No description provided.

This change removes the generation of events by the serving certificate
controller because it doesn't work well with the cert/key file provider.

Signed-off-by: Simon Pasquier <[email protected]>
@simonpasquier simonpasquier requested a review from a team as a code owner November 13, 2024 12:51
@simonpasquier simonpasquier requested review from jan--f and PeterYurkovich and removed request for a team November 13, 2024 12:51
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 13, 2024

@simonpasquier: This pull request references COO-526 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from danielmellado November 13, 2024 12:51
Copy link

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier
Copy link
Contributor Author

/retest-required

@jan--f
Copy link
Collaborator

jan--f commented Nov 14, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4732d43 into rhobs:main Nov 14, 2024
11 checks passed
@simonpasquier simonpasquier deleted the COO-526-2 branch November 14, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants