COO-186: fix: add korrel8r proxy configuration to logging view plugin #515
Conversation
jgbernalp
requested review from
sthaha and
JoaoBraveCoding
and removed request for
a team
|
@jgbernalp: This pull request references COO-186 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -62,6 +62,16 @@ func createLoggingPluginInfo(plugin *uiv1alpha1.UIPlugin, namespace, name, image | |||
| Port: 8080, | |||
| }, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Is it ok to create the proxy entry even when the korrel8r plugin isn't installed?
There was a problem hiding this comment.
I think is ok as the console proxy just allows the plugin to communicate to the in cluster service. If the korrel8r deployment/service fails, or is not there, requests will fail and the plugin won't show the correlation links.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp, periklis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds the korrel8r proxy configuration so the the logging view plugin can discover korrel8r and correlation links are shown.