chore: fix assertAlertmanagersAreResilientToDisruption() #454
Conversation
simonpasquier
requested review from
sthaha and
slashpai
and removed request for
a team
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm seems like we'll be seeing a few of those go1.22 issues around |
I suspect that the test was flaky because it uses the address of the loop variable (see https://go.dev/blog/loopvar-preview). Signed-off-by: Simon Pasquier <[email protected]>
simonpasquier
force-pushed
the
fix-assertAlertmanagersAreResilientToDisruption
branch
from
fcae7ed to
f4558d4
Compare
|
@simonpasquier: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
|
After all I'm not sure that it's the bug because it failed on the same test. Trying an updated version where all evictions are executed serially then we check the errors. Let's see if it helps but IIUC we're still subject to race conditions if the evicted pods get ready before the last eviction... The more robust version would be to mark all nodes as unschedulable before the test. |
|
/lgtm |
simonpasquier
deleted the
fix-assertAlertmanagersAreResilientToDisruption
branch
|
The case failed again and even failed in the upstream ci, refer |
I suspect that the test was flaky because it uses the address of the loop variable (see https://go.dev/blog/loopvar-preview).