Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/prometheus/common from 0.46.0 to 0.49.0 #429

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

danielmellado
Copy link
Contributor

@danielmellado danielmellado commented Mar 1, 2024

This commit also addresses the change in prometheus/common making
expfmt.FmtText unexported.

Signed-off-by: Daniel Mellado [email protected]

@danielmellado danielmellado requested a review from a team as a code owner March 1, 2024 07:51
@danielmellado danielmellado requested review from simonpasquier and JoaoBraveCoding and removed request for a team March 1, 2024 07:51
@openshift-ci openshift-ci bot requested review from jan--f and sthaha March 1, 2024 07:52
Copy link

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 1, 2024
@danielmellado danielmellado force-pushed the dependabot-prometheus-bump branch from 1da1a88 to d132d6a Compare March 1, 2024 07:54
@danielmellado danielmellado changed the title Pull request for dependabot-prometheus-bump build(deps): bump github.com/prometheus/common from 0.46.0 to 0.49.0 Mar 1, 2024
This commit also addresses the change in prometheus/common making
expfmt.FmtText unexported.

Signed-off-by: Daniel Mellado <[email protected]>
@danielmellado danielmellado force-pushed the dependabot-prometheus-bump branch from d132d6a to cd36b12 Compare March 1, 2024 08:20
Copy link

openshift-ci bot commented Mar 1, 2024

@danielmellado: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/observability-operator-e2e cd36b12 link true /test observability-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danielmellado
Copy link
Contributor Author

@jan--f looks like I'm hitting the same issue as you had with the multi-ns test, I'll ping you to sync up about it but we should deff refactor this

@jan--f
Copy link
Collaborator

jan--f commented Mar 11, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 11, 2024
@jan--f jan--f merged commit ad5dc03 into rhobs:main Mar 11, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants