WIP: [OSD-22023] Add new deduplicated metric for vcpus. #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmannf
force-pushed
the
osd-22023-add-deduped-vcpus-metric
branch
from
a3660eb to
ac5ef62
Compare
bergmannf
force-pushed
the
osd-22023-add-deduped-vcpus-metric
branch
from
ac5ef62 to
a18267e
Compare
|
@bergmannf I believe you need to additionally add the metric to the template, see #680 |
bergmannf
force-pushed
the
osd-22023-add-deduped-vcpus-metric
branch
2 times, most recently
from
786496e to
ba126a0
Compare
|
/retest |
|
@bergmannf @typeid: it seems like the build fails because of an issue we had in the past, which is already fixed in the more recent commits. If you pull-in the latest commits from |
This metric is being forwarded, as a deduplicated metrics. See: OSD-22023 for more information.
bergmannf
force-pushed
the
osd-22023-add-deduped-vcpus-metric
branch
from
ba126a0 to
8b9bd75
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This metric is being forwarded, as a deduplicated metrics.
See: OSD-22023 for more information.