unit test improvement/fixes #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As the unit tests currently fail due to a change in rawhide(first seen in PR #2922), this provides a good opportunity to validate that the log cat works as intended. 😁 |
|
rpm-tests failure is https://bugzilla.redhat.com/show_bug.cgi?id=1887969 FTR |
|
Yes, so we can now see the failure directly in the output, and have a convenient way to link to it: https://github.com/rhinstaller/anaconda/pull/2923/checks?check_run_id=1251662037#step:6:1485 |
martinpitt
added a commit
to martinpitt/anaconda
that referenced
this pull request
Oct 14, 2020
pylint hits 2 GiB per process pretty often [1], thus still causing OOM failures [2]. Bump the divisor. [1] pylint-dev/pylint#1495 [2] pylint-dev/pylint#3899 Cherry-picked from master PR rhinstaller#2923 Related: rhbz#1885635
martinpitt
added a commit
to martinpitt/anaconda
that referenced
this pull request
Oct 14, 2020
With the variable reorg in commit a452f1b, `CI_TASKS_TEST_ARGS` already contains the volume mount and `--rm`, so it's not necessary any more to repeat it -- in fact, that fails: Error: /anaconda: duplicate mount destination Cherry-picked from master PR rhinstaller#2923 Related: rhbz#1885635
martinpitt
added a commit
to martinpitt/anaconda
that referenced
this pull request
Oct 14, 2020
max() was bogus -- we want *both* RAM and number of CPUs to limit the number of jobs, not take whichever is highest. [1] pylint-dev/pylint#1495 [2] pylint-dev/pylint#3899 Cherry-picked from master PR rhinstaller#2923 Related: rhbz#1885635
martinpitt
added a commit
to martinpitt/anaconda
that referenced
this pull request
Oct 14, 2020
With the variable reorg in commit a452f1b, `CI_TASKS_TEST_ARGS` already contains the volume mount and `--rm`, so it's not necessary any more to repeat it -- in fact, that fails: Error: /anaconda: duplicate mount destination Cherry-picked from master PR rhinstaller#2923 Related: rhbz#1885635
martinpitt
force-pushed
the
unit-tests
branch
from
e6239c5 to
0b812aa
Compare
martinpitt
added a commit
to martinpitt/anaconda
that referenced
this pull request
Oct 14, 2020
max() was bogus -- we want *both* RAM and number of CPUs to limit the number of jobs, not take whichever is highest. Cherry-picked from master PR rhinstaller#2923 Related: rhbz#1885635
martinpitt
added a commit
to martinpitt/anaconda
that referenced
this pull request
Oct 14, 2020
With the variable reorg in commit a452f1b, `CI_TASKS_TEST_ARGS` already contains the volume mount and `--rm`, so it's not necessary any more to repeat it -- in fact, that fails: Error: /anaconda: duplicate mount destination Cherry-picked from master PR rhinstaller#2923 Related: rhbz#1885635
martinpitt
added a commit
to martinpitt/anaconda
that referenced
this pull request
Oct 14, 2020
We want *both* RAM and number of CPUs to limit the number of jobs, not take whichever is highest, and we want *at least* one job. So flip max/min around to actually make sense. Cherry-picked from master PR rhinstaller#2923 Related: rhbz#1885635
martinpitt
added a commit
to martinpitt/anaconda
that referenced
this pull request
Oct 14, 2020
With the variable reorg in commit a452f1b, `CI_TASKS_TEST_ARGS` already contains the volume mount and `--rm`, so it's not necessary any more to repeat it -- in fact, that fails: Error: /anaconda: duplicate mount destination Cherry-picked from master PR rhinstaller#2923 Related: rhbz#1885635
martinpitt
added a commit
to martinpitt/anaconda
that referenced
this pull request
Oct 14, 2020
pylint hits 2 GiB per process pretty often [1], thus still causing OOM failures [2]. Bump the divisor. [1] pylint-dev/pylint#1495 [2] pylint-dev/pylint#3899 Cherry-picked from master PR rhinstaller#2923 Related: rhbz#1885635
martinpitt
added a commit
to martinpitt/anaconda
that referenced
this pull request
Oct 14, 2020
With the variable reorg in commit a452f1b, `CI_TASKS_TEST_ARGS` already contains the volume mount and `--rm`, so it's not necessary any more to repeat it -- in fact, that fails: Error: /anaconda: duplicate mount destination Cherry-picked from master PR rhinstaller#2923 Related: rhbz#1885635
1 task
We want *both* RAM and number of CPUs to limit the number of jobs, not take whichever is highest, and we want *at least* one job. So flip max/min around to actually make sense.
pylint hits 2 GiB per process pretty often [1], thus still causing OOM failures [2]. Bump the divisor. [1] pylint-dev/pylint#1495 [2] pylint-dev/pylint#3899
It's more convenient to look at it directly on the workflow run page than downloading and unpacking logs.zip.
martinpitt
force-pushed
the
unit-tests
branch
from
0b812aa to
7534437
Compare
poncovka
approved these changes
Oct 14, 2020
|
Ported to rhel-8 branch in PR #2920 |
jkonecny12
requested changes
Oct 14, 2020
martinpitt
force-pushed
the
unit-tests
branch
from
7534437 to
34d8bb5
Compare
With the variable reorg in commit a452f1b, `CI_TASKS_TEST_ARGS` already contains the volume mount and `--rm`, so it's not necessary any more to repeat it -- in fact, that fails: Error: /anaconda: duplicate mount destination
|
I put back the "Fix ci-tasks container shell instructions" commit as per discussion with @jkonecny12 , and we'll fix the "run single test" separately in #2925. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.